[FFmpeg] Add --enable-libpulse

[Martmists-GH]

Fixes #1471

[Martmists-GH]

Not sure why tests are failing, seems to be unrelated to my code.

@saudet How long does it usually take for PRs to get merged?

[saudet]

The builds are failing. That needs to be fixed

[Martmists-GH]

I'm not sure how, it seems to be failing on packages and I didn't touch those

[saudet]

2024-02-16T14:50:25.4392008Z require_pkg_config libpulse libpulse pulse/pulseaudio.h pa_context_new
2024-02-16T14:50:25.4392242Z check_pkg_config libpulse libpulse pulse/pulseaudio.h pa_context_new
2024-02-16T14:50:25.4392495Z test_pkg_config libpulse libpulse pulse/pulseaudio.h pa_context_new
2024-02-16T14:50:25.4392652Z false --exists --print-errors libpulse
2024-02-16T14:50:25.4392825Z ERROR: libpulse not found using pkg-config
2024-02-16T14:50:25.4393082Z Makefile:186: /tests/Makefile: No such file or directory
2024-02-16T14:50:25.4393312Z make: *** No rule to make target '/tests/Makefile'.  Stop.

[streamingdv]

@Martmists-GH just a hint, you enabled libpulse in ffmpeg so you must guarantee that the required libs and headers are available on all build systems (android, linux, mac, windows). This seems not to be the case so all ffmpeg builds are failing

[Martmists-GH]

What should I do then? I can build ffmpeg just fine on my PC

[streamingdv]

As you can see the builds are failing clearly because of your changes (look at the answer of saudet). If you want to include a new feature like libpulse you must guarantee that the ffmpeg builds will pass for all available platforms, not just one. If it works on your PC the ffmpeg build is able to detect necessary dependencies and libs to build it with libpulse enabled but as you can see that's not the case for the build systems of javacpp-presets. In the .github/actions folder you have the individual setups for each build system (deploy-ubuntu, deploy-windows...) which you need to configure appropriately for building ffmpeg with libpulse support.

Edit: and you can test the whole build process yourself in your branch via the GitHub action scripts.

[Martmists-GH]

@streamingdv I'm not quite sure why this is failing, I installed libpulse-dev but pkg-config seems to still fail to find it? I'm not familiar with ubuntu but from I can gather online this should work

[streamingdv]

I don't know either but I made a similar pull request recently to enable vulkan for ffmpeg and I had to make sure the change works on all platforms. Only Android wasn't possible because of Google NDK limitations but you have to test it by yourself via the github actions in your fork. I was only trying to provide some general information about how pull requests work here :) Here was my pull request as a reference

https://github.com/bytedeco/javacpp-presets/pull/1460/files

The libpulse-dev package might not be available for linux arm and other systems so either you have to find a way to install the lib or if it's not possible then explain why. I do not see that you have modified the '.github/actions/deploy-ubuntu/action.yml' script but that might be needed in order to prepera the build system to have the necessary libraies available.

Edit: oh okay sorry I saw that you have edited the 'deploy-ubuntu/action.yml' but maybe that's not enough to make it work on all linux builds.