Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presets for nvCOMP #1434

Merged
merged 14 commits into from
Nov 15, 2023
Merged

Add presets for nvCOMP #1434

merged 14 commits into from
Nov 15, 2023

Conversation

ds58
Copy link
Contributor

@ds58 ds58 commented Nov 1, 2023

I added bindings for nvCOMP, a CUDA library for GPU accelerated lossless compression algorithms.
https://developer.nvidia.com/nvcomp

If you see the nvcomp InfoMapper, I left a TODO comment about a linking issue on Windows. Maybe you can spot something I did wrong, but I couldn't get the linking to work correctly for those symbols. Also, I will have to change the CUDA workflow back before merging, I changed it for testing the CI.

@ds58
Copy link
Contributor Author

ds58 commented Nov 2, 2023

Looks like linux-arm64 CI is failing...
error: ‘nvcompBitcompFormatOpts’ was not declared in this scope; did you mean ‘nvcompCascadedFormatOpts’?
Not sure why, I'll have to look into it.

@saudet
Copy link
Member

saudet commented Nov 3, 2023 via email

@ds58
Copy link
Contributor Author

ds58 commented Nov 3, 2023

Okay, sounds good. I've removed the nvCOMP installation for linux-arm64 in CI and the InfoMapper platform value for linux-arm64.

@saudet
Copy link
Member

saudet commented Nov 4, 2023

No, I meant we can skip nvcompBitcompFormatOpts. If it doesn't work on one platform, it probably doesn't work correctly on all platforms.

@ds58
Copy link
Contributor Author

ds58 commented Nov 6, 2023

I've commented out the bitcomp headers. I had linking issues with them on Windows and then the compile issues on linux-arm64. I think perhaps we just skip bitcomp for now.

@saudet
Copy link
Member

saudet commented Nov 7, 2023

The error on linux-arm64 is just about nvcompBitcompFormatOpts, so if you skip that it should be fine. Please try to do that instead of disabling everything.

cuda/README.md Outdated Show resolved Hide resolved
@saudet
Copy link
Member

saudet commented Nov 14, 2023

This looks good to merge, so please revert the temporary changes to the workflow. Thanks!

@saudet saudet merged commit 212e7a8 into bytedeco:master Nov 15, 2023
2 of 5 checks passed
@ds58 ds58 deleted the nvcomp branch November 16, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants