Add macosx-arm64 preset for lz4 #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For consistency, everything "macosx-arm64" should appear before "macosx-x86_64", and we'll need to cross compile in cppbuild.sh, but the rest looks fine. |
|
|
I don't think the target flag is going to work. Anyway, it's easier to use just "-arch arm64" and that's been working for all other builds, for example: https://github.com/bytedeco/javacpp-presets/blob/master/libffi/cppbuild.sh#L90 |
gab1one
force-pushed
the
add-mac-arm64-support-to-lz4
branch
from
eea32bc
to
c156a4f
Compare
|
Thanks for the tip, that seems to be working when running clang on mac. |
|
Is there anything else missing for this to get merged? |
|
Thank you very much for the support and merging 👍🏾 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the build of the macosx-arm64 preset for lz4.
Build is working, please let me know if anything else is missing.
(I created the PR with the wrong account earlier, that is why I closed that one and opened this one)