Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce linux-arm64 to presets for libpostal #1199

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Introduce linux-arm64 to presets for libpostal #1199

merged 3 commits into from
Jul 28, 2022

Conversation

MasseGuillaume
Copy link
Contributor

No description provided.

@MasseGuillaume MasseGuillaume force-pushed the libpostal-linux-arm64 branch 2 times, most recently from 57c7e35 to be1fa26 Compare July 9, 2022 15:05
@saudet
Copy link
Member

saudet commented Jul 11, 2022

Looks good, but please fix the builds on GitHub Actions! Also, there's a couple of missing entries in platform/pom.xml.

@MasseGuillaume
Copy link
Contributor Author

Hi, sorry for the delay I was on vacation. It looks like the failure was related to some changes in GitHub unrelated to this PR:

Downloading https://github.com/openvenues/libpostal/archive/v1.1.tar.gz gives the following error:

the given path has multiple possibilities: #Git::Ref:0x00007fd6613eefb0, #Git::Ref:0x00007fd6613ee8d0

I fixed the URL by adding refs tags to remove the ambiguity. I will need your approval to re-run the Github actions.

@saudet
Copy link
Member

saudet commented Jul 25, 2022

https://github.com/openvenues/libpostal/archive/refs/tags/v1.1.tar.gz seems to be working correctly. Let's use that?

@MasseGuillaume
Copy link
Contributor Author

Yup that's the fix I'm trying right now.
aff6294#diff-ae4eed1b337db40a14189f50b893c841de813757ab17c9f41e6d903263ab6f86R11

@MasseGuillaume
Copy link
Contributor Author

Hum something is off

[INFO] Detected platform "linux-x86_64"
[INFO] Building platform "linux-arm64"

I think it might be related to the missing manifestEntry in the pom file. I added the change and pushed here:

00d4297#diff-95113202bf744a6965dfbcb1a37d7690d52ae6258cabed7bb1e5245921450e63

@MasseGuillaume
Copy link
Contributor Author

I will need your approval once again to run the workflow.

@saudet
Copy link
Member

saudet commented Jul 26, 2022

Hum something is off

[INFO] Detected platform "linux-x86_64"
[INFO] Building platform "linux-arm64"

I think it might be related to the missing manifestEntry in the pom file. I added the change and pushed here:

No, that's alright. GitHub Actions doesn't have ARM runners, yet, so we need to cross compile.

@MasseGuillaume
Copy link
Contributor Author

Ah ok I understand now, I added the cross-compilation flag: --host=aarch64-linux-gnu to ./configure:

https://github.com/bytedeco/javacpp-presets/pull/1199/files#diff-ae4eed1b337db40a14189f50b893c841de813757ab17c9f41e6d903263ab6f86R38

If you can allow the CI to run, I think this time it should work.

@MasseGuillaume
Copy link
Contributor Author

Great, it looks like we now have a linux-arm64 libpostal: https://github.com/MasseGuillaume/javacpp-presets/runs/7520138130

@MasseGuillaume
Copy link
Contributor Author

I think this PR is all good for a merge, did I miss anything?

@saudet saudet merged commit f2705ee into bytedeco:master Jul 28, 2022
@MasseGuillaume MasseGuillaume deleted the libpostal-linux-arm64 branch July 31, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MasseGuillaume @saudet