Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NVIDIA Video Codec Preset for Windows #1020

Merged
merged 16 commits into from
Mar 25, 2021
Merged

Added NVIDIA Video Codec Preset for Windows #1020

merged 16 commits into from
Mar 25, 2021

Conversation

devjeonghwan
Copy link
Member

@devjeonghwan devjeonghwan commented Mar 19, 2021

Fixed #1008
Fixed #1026

@devjeonghwan
Copy link
Member Author

That sample java code based on nvidia official nvidia video codec sample c++ code.

@saudet
Copy link
Member

saudet commented Mar 19, 2021

Thanks! I'm wondering though, could we use the header files from https://github.com/FFmpeg/nv-codec-headers?
That way we wouldn't need to download and install the SDK separately.

@devjeonghwan
Copy link
Member Author

@saudet i think header files is fine. but missing nvcuvid link file.

@devjeonghwan
Copy link
Member Author

ok, let's test compile with "replace official sdk header files to that repository header files" and "use official link(dll) file". and i will let you know result.

@saudet
Copy link
Member

saudet commented Mar 19, 2021

Yeah, that's not going to work. We'll need to do the same as TensorRT here I'm afraid:
https://github.com/bytedeco/javacpp-presets/blob/master/.github/actions/deploy-centos/action.yml#L95

@devjeonghwan
Copy link
Member Author

okey, you mean "write 'download video sdk and unzip' code to each platform github action", right?

@saudet
Copy link
Member

saudet commented Mar 19, 2021

Yes, it's only Linux and Windows, but it's still annoying.

@devjeonghwan
Copy link
Member Author

i will upload each platform nvcodec SDK files to google driver and modify github action script.

btw, why you didn't check downloaded file hash check? isn't dangerous? (if i upload modulated dll to google driver and i link it...? it is terrible)

@saudet
Copy link
Member

saudet commented Mar 20, 2021 via email

@devjeonghwan
Copy link
Member Author

I added git actions and fix small sample problem.

@saudet
Copy link
Member

saudet commented Mar 22, 2021

Please add a workflow for GitHub Actions here to get this tested:
https://github.com/bytedeco/javacpp-presets/tree/master/.github/workflows

@devjeonghwan
Copy link
Member Author

Sorry, i added

@devjeonghwan
Copy link
Member Author

Ah... something happen.. should i have to change nvcodec dependency javacpp version 1.5.5-snap to 1.5.6-snap?

@devjeonghwan
Copy link
Member Author

devjeonghwan commented Mar 22, 2021

oops.. i forgot linux support code in pom.xml... so i commited.... xD but i don't know why windows build failure

@devjeonghwan
Copy link
Member Author

i will close this pr and check again.

@devjeonghwan
Copy link
Member Author

oh.. i found reason.. i think we need merge nvcodec action file to bytedeco/javacpp-presets@action branche

nvcodec/README.md Outdated Show resolved Hide resolved
nvcodec/platform/pom.xml Outdated Show resolved Hide resolved
nvcodec/platform/redist/pom.xml Outdated Show resolved Hide resolved
@devjeonghwan
Copy link
Member Author

I pushed

nvcodec/README.md Outdated Show resolved Hide resolved
nvcodec/samples/pom.xml Outdated Show resolved Hide resolved
@devjeonghwan
Copy link
Member Author

Fixed #1026

@devjeonghwan
Copy link
Member Author

devjeonghwan commented Mar 24, 2021

Sorry for force push. i pushed a file I didn't care about by my mistake.

BTW, @saudet i have to push tensorrt javadoc encoding config(#1026) to this PR? or i make another PR?

@saudet
Copy link
Member

saudet commented Mar 25, 2021

Feel free to include the fix for TensorRT in this PR. Thanks!

@devjeonghwan
Copy link
Member Author

Nice!

@saudet
Copy link
Member

saudet commented Mar 25, 2021

Hey, I'd like to fix a few nits before merging this. Can you give me push access to this branch?

@devjeonghwan
Copy link
Member Author

Invited!

@saudet
Copy link
Member

saudet commented Mar 25, 2021

Ok, this looks good to merge! Let me know if this looks to you.

@devjeonghwan
Copy link
Member Author

@saudet that goes without saying! nice!

@saudet saudet merged commit eb6ca2c into bytedeco:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javadoc Encoding Issue SharedLibrary type preset build problem
2 participants