Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Wasmer Bindings #173

Closed
wants to merge 9 commits into from

Conversation

syrusakbary
Copy link

@syrusakbary syrusakbary commented Mar 16, 2022

Today members from our community were asking for the latest up-to-date Wasmer wit-bindings, so I think it now makes sense to try to bring this effort upstream!

This PR implements both:

  • Wasmer-Rust bindings
  • Wasmer-Python bindings

Along with the end to end tests passing for both binding implementations.
Please let us know if there is anything that we need to do to iterate on the codebase. We'll be more than happy to iterate on them!

Thanks, and keep up the good work

@tschneidereit
Copy link
Member

Thank you for opening this PR. However, nothing's really changed in a fundamental way since Alex's comment in #56 (comment): wit-bindgen itself will continue undergoing churn for the foreseeable future, and we're not able to bear the inevitable cost that having additional 3rd-party bindings in the repository would bring.

To manage expectations for the future though, while we haven't decided on any kind of formal policy, I'm not sure we'll ever want to maintain an open-ended list of 3rd-party bindings in this repository. wit-bindgen is a project with specific stakeholders working on it with specific goals in mind, and we need to ensure that we stay focused on these. We'll base decisions around which bindings to host here strictly on whether we see it as beneficial to wit-bindgen as a project and its stakeholders, on a case-by-case basis.

Since we do appreciate that it's attractive to make use of the work done here without having to invest the considerable effort to do and maintain a full separate implementation, we structured wit-bindgen in a way that makes it easy to maintain bindings externally and make use of wit-bindgen through an API. While that API will necessarily undergo churn for a while, too, we aim to eventually have that settle down and follow semver versioning. I'd encourage you to investigate making use of this for your bindings.

Given the above, I'll close this PR.

@syrusakbary syrusakbary mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants