Do not deallocate disabled GC heaps via the instance allocator #9180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the reference types proposal is disabled, we don't allocate a GC heap from the instance allocator, we instead create a `DisabledGcHeap`. Rather than returning this to the instance allocator when we're done with it, which won't even know what to do with it since the instance allocator didn't create the GC heap, we simply rely on the `DisabledGcHeap`'s `Drop` implementation.
alexcrichton
approved these changes
Aug 28, 2024
crates/wasmtime/src/runtime/store.rs
Outdated
| .features() | ||
| .contains(wasmparser::WasmFeatures::REFERENCE_TYPES) | ||
| { | ||
| let (index, heap) = if engine.features().reference_types() { |
There was a problem hiding this comment.
While you're here mind handling #9162 here as well and renaming reference_types in this PR to gc_types instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the reference types proposal is disabled, we don't allocate a GC heap from the instance allocator, we instead create a
DisabledGcHeap. Rather than returning this to the instance allocator when we're done with it, which won't even know what to do with it since the instance allocator didn't create the GC heap, we simply rely on theDisabledGcHeap'sDropimplementation.