Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more clippy::doc_lazy_continuation lints #9105

Conversation

waywardmonkeys
Copy link
Contributor

This fixes all remaining instances of clippy::doc_lazy_continuation except for in some generated code.

@waywardmonkeys waywardmonkeys requested review from a team as code owners August 11, 2024 14:32
@waywardmonkeys waywardmonkeys requested review from cfallin and pchickey and removed request for a team August 11, 2024 14:32
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:meta Everything related to the meta-language. isle Related to the ISLE domain-specific language wasi Issues pertaining to WASI wasmtime:api Related to the API of the `wasmtime` crate itself winch Winch issues or pull requests labels Aug 11, 2024
Copy link

Subscribe to Label Action

cc @cfallin, @fitzgen, @saulecabrera

This issue or pull request has been labeled: "cranelift", "cranelift:meta", "isle", "wasi", "wasmtime:api", "winch"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle
  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm curious though, how did you see this warning? We should in theory have all lints allowed for clippy by default except a few listed in the top-level Cargo.toml. Do you know how that configuration was ignored?

Orthogonally, if you're up for it, adding this lint to Cargo.toml to have this checked on CI I think would make sense.

@waywardmonkeys
Copy link
Contributor Author

I found them because I'd added it to the top level Cargo to enable it. :)

I'd wanted to enable it in the commit, but ran into an issue with a couple of remaining ones in generated code and didn't quite have the time at the moment to fix them, but also didn't want merge conflicts on these if I let it all sit until I had the time.

@alexcrichton
Copy link
Member

Oops I meant to flag this for merge yesterday. Doing so now.

Also makes sense! And yeah feel free to enable them at the top-level too. It's ok to add #[allow] to generated code as we've done that for ISLE code before (we can perhaps change that to allow(clippy::all) too or something like that)

@alexcrichton alexcrichton added this pull request to the merge queue Aug 13, 2024
Merged via the queue into bytecodealliance:main with commit 38d6fb6 Aug 13, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:meta Everything related to the meta-language. cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language wasi Issues pertaining to WASI wasmtime:api Related to the API of the `wasmtime` crate itself winch Winch issues or pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants