Switch to new "user" stack maps and use i32 for GC refs in Wasmtime
#9082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves Wasmtime over from the old, regalloc-based stack maps system to the new "user" stack maps system. Removing the old regalloc-based stack maps system is left for follow-up work.
fitzgen
force-pushed
the
wasmtime-use-new-stack-maps
branch
from
1dedef5
to
ac4bec2
Compare
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "cranelift:wasm", "fuzzing", "wasmtime:api", "wasmtime:ref-types"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
elliottt
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves Wasmtime over from the old, regalloc-based stack maps system to the new "user" stack maps system.
Removing the old regalloc-based stack maps system is left for follow-up work.
All tests are passing, and I've been running the
table_opsfuzz target (which exercises GC refs, passing them between the host and Wasm, and their inline barriers) locally for a while with no more issues found (there was initially one issue found which was fixed in #9071).