Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-programs: reorganize wasi content generated by wit and remove unnecessary deps #9080

Merged
merged 1 commit into from
Aug 6, 2024
Merged

test-programs: reorganize wasi content generated by wit and remove unnecessary deps #9080

merged 1 commit into from
Aug 6, 2024

Conversation

iawia002
Copy link
Contributor

@iawia002 iawia002 commented Aug 6, 2024

A better version of #8939, since wit-bindgen now supports parse WIT files from multiple paths.

@iawia002 iawia002 requested review from a team as code owners August 6, 2024 02:15
@iawia002 iawia002 requested review from alexcrichton and removed request for a team August 6, 2024 02:15
@github-actions github-actions bot added the wasi Issues pertaining to WASI label Aug 6, 2024
pchickey
pchickey approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@pchickey pchickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pchickey pchickey added this pull request to the merge queue Aug 6, 2024
Merged via the queue into bytecodealliance:main with commit 25ea52a Aug 6, 2024
37 checks passed
@iawia002 iawia002 deleted the wit branch August 7, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchickey pchickey pchickey approved these changes

@alexcrichton alexcrichton Awaiting requested review from alexcrichton alexcrichton is a code owner automatically assigned from bytecodealliance/wasmtime-core-reviewers

Assignees
No one assigned
Labels
wasi Issues pertaining to WASI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iawia002 @pchickey