x64: Fix encoding of adc/sbb with immediate operands #8976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't reachable from Cranelift today but in some various testing this is one of the issues I encountered. This fixes apparent copy/paste bugs with the `Adc` and `Sbb` instructions with immediate operands.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Aug 19, 2024
This commit is similar to bytecodealliance#8976 where it's fixing some typos in the encoding of the `adc` and `sbb` instructions used in Cranelift. These appear to have copy/paste typos where the non-register-based opcodes weren't updated from the `add` and `sub` opcodes. This problem was exposed from a fuzz test case after bytecodealliance#9136 landed. The fuzz test case is minimized and included here as a new runtest and new emit tests are additionally added.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
This commit is similar to #8976 where it's fixing some typos in the encoding of the `adc` and `sbb` instructions used in Cranelift. These appear to have copy/paste typos where the non-register-based opcodes weren't updated from the `add` and `sub` opcodes. This problem was exposed from a fuzz test case after #9136 landed. The fuzz test case is minimized and included here as a new runtest and new emit tests are additionally added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't reachable from Cranelift today but in some various testing this is one of the issues I encountered. This fixes apparent copy/paste bugs with the
AdcandSbbinstructions with immediate operands.