cranelift-frontend: Specify stack map behavior when defining variables
#8937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
requested review from
cfallin and
alexcrichton
and removed request for
a team
fitzgen
force-pushed
the
variables-need-stack-maps-too
branch
from
4190e22
to
ae51bc8
Compare
github-actions
bot
added
cranelift
bjorn3
reviewed
Jul 11, 2024
Instead of adding a parameter to `declare_var`
alexcrichton
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that all uses of the variable are automatically marked as needing stack maps, which is a big simplification and removal of potential footguns for users.