Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cranelift: Remove resumable traps #8809

Merged
merged 1 commit into from
Jun 14, 2024

Commits on Jun 14, 2024

  1. Cranelift: Remove resumable traps

    These were originally a SpiderMonkey-ism and have been unused ever
    since. It was introduced for GC integration, where the runtime could do
    something to make Cranelift code hit a trap and pause for a GC and then resume
    execution once GC completed. But it is unclear that, as implemented, this is
    actually a useful mechanism for doing that (compared to, say, loading from some
    Well Known page and the GC protecting that page and catching signals to
    interrupt the mutator, or simply branching and doing a libcall). And if someone
    has that particular use case in the future (Wasmtime and its GC integration
    doesn't need exactly this) then we can design something for what is actually
    needed at that time, instead of carrying this cruft forward forever.
    fitzgen committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    f0f6b0e View commit details
    Browse the repository at this point in the history