Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try migrating to a "more official" github pages provider #8800

Merged

Conversation

alexcrichton
Copy link
Member

This commit is an attempt to migrate from
JamesIves/github-pages-deploy-action, a third party action, to what appears to be a more official action under the github.com/actions organization. This was first pioneered in
bytecodealliance/wasm-tools#1597 and it looked like it would work well over here too.

This commit is an attempt to migrate from
`JamesIves/github-pages-deploy-action`, a third party action, to what
appears to be a more official action under the `github.com/actions`
organization. This was first pioneered in
bytecodealliance/wasm-tools#1597 and it looked like it would work well
over here too.
@alexcrichton alexcrichton requested a review from a team as a code owner June 13, 2024 22:18
@alexcrichton alexcrichton requested review from cfallin and removed request for a team June 13, 2024 22:18
alexcrichton added a commit to alexcrichton/wasmtime-py that referenced this pull request Jun 13, 2024
alexcrichton added a commit to bytecodealliance/wasmtime-py that referenced this pull request Jun 13, 2024
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

@alexcrichton alexcrichton added this pull request to the merge queue Jun 13, 2024
Merged via the queue into bytecodealliance:main with commit ff87114 Jun 13, 2024
36 checks passed
@alexcrichton alexcrichton deleted the deploy-with-gh-pages branch June 13, 2024 22:49
alexcrichton added a commit to alexcrichton/wasmtime that referenced this pull request Jun 13, 2024
I deleted too much of the previous logic in bytecodealliance#8800
github-merge-queue bot pushed a commit that referenced this pull request Jun 13, 2024
I deleted too much of the previous logic in #8800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants