Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift: Delete scalar {u,s}loadNN and storeNN instructions #8785

Closed
wants to merge 5 commits into from

Commits on Jun 11, 2024

  1. Configuration menu
    Copy the full SHA
    0647cd3 View commit details
    Browse the repository at this point in the history
  2. wasmtime: Use regular store operations for small stores

    Instead of using the `istore8` special store opcodes, perform a ireduce and then store.
    afonso360 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    de776a0 View commit details
    Browse the repository at this point in the history
  3. cranelift: Delete istoreNN instructions

    These instructions are essentially a combination of a `ireduce+store`, so remove the special store, and start recognizing that idiom in the backends.
    
    Since `ireduce` is a no-op from the point of view of the backends, we can simply delete those lowering rules. they don't add any novel instructions other than just separately lowering both `ireduce` and `store`.
    
    There are a lot of s390x tests delete here, I've checked and there also exist equivalent `store` based tests for those, so no point in keeping them around.
    afonso360 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8344085 View commit details
    Browse the repository at this point in the history
  4. wasmtime: Don't use {u,s}storeNN instructions

    These are going to be removed in follow up commits
    afonso360 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    297af1e View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Configuration menu
    Copy the full SHA
    67dde0c View commit details
    Browse the repository at this point in the history