wasmtime: VMRuntimeLimits pointer is already SSA
#8689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to use cranelift-frontend to keep track of the location of the `VMRuntimeLimits` pointer, because it is loaded once on entry to the function and never changed afterward. Instead, just track the correct SSA `Value`.
fitzgen
approved these changes
May 24, 2024
crates/cranelift/src/func_environ.rs
Outdated
| let vmctx = self.vmctx(builder.func); | ||
| let base = builder.ins().global_value(pointer_type, vmctx); | ||
| let offset = i32::try_from(self.offsets.vmctx_runtime_limits()).unwrap(); | ||
| let interrupt_ptr = builder | ||
| .ins() | ||
| .load(pointer_type, ir::MemFlags::trusted(), base, offset); | ||
| builder.def_var(self.vmruntime_limits_ptr, interrupt_ptr); | ||
| self.vmruntime_limits_ptr = interrupt_ptr; |
There was a problem hiding this comment.
Can we debug assert that self.vmruntime_limits_ptr is the reserved value before we initialize it, to make sure that we aren't defining it multiple times? And/or use an Option or PackedOption for the field?
| ( | ||
| builder.use_var(self.vmruntime_limits_ptr), | ||
| self.vmruntime_limits_ptr, |
There was a problem hiding this comment.
Similarly, can we debug assert that it has been initialized here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to use cranelift-frontend to keep track of the location of the
VMRuntimeLimitspointer, because it is loaded once on entry to the function and never changed afterward.Instead, just track the correct SSA
Value.