fix(c-api): give a cleaner error message if cargo isn't found #8497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
approved these changes
Apr 29, 2024
Instead of > Performing build step for 'wasmtime-crate''WASMTIME_CARGO_BINARY-NOTFOUND' is not recognized as an internal or external command, operable program or batch file. this will now instead output > "cargo" was not found. Ensure "cargo" is in PATH. Aborting...
dundargoc
force-pushed
the
fix/error_message
branch
from
3332afa
to
23346a9
Compare
fitzgen
approved these changes
Apr 29, 2024
dundargoc
added a commit
to dundargoc/wasmtime
that referenced
this pull request
May 7, 2024
…dealliance#8497) Instead of > Performing build step for 'wasmtime-crate''WASMTIME_CARGO_BINARY-NOTFOUND' is not recognized as an internal or external command, operable program or batch file. this will now instead output > "cargo" was not found. Ensure "cargo" is in PATH. Aborting...
alexcrichton
pushed a commit
that referenced
this pull request
May 7, 2024
* fix(c-api): give a cleaner error message if cargo isn't found (#8497) Instead of > Performing build step for 'wasmtime-crate''WASMTIME_CARGO_BINARY-NOTFOUND' is not recognized as an internal or external command, operable program or batch file. this will now instead output > "cargo" was not found. Ensure "cargo" is in PATH. Aborting... * c-api: use `--release` when MinSizeRel and RelWithDebInfo is used (#8549) * build: add "fastest-runtime" profile for runtime optimization (#8554) This is extremely useful for cases where the default optimizations just are not enough. Background: [neovim](https://github.com/neovim/neovim) is interested to add wasmtime support in neovim/neovim#28415 but we noticed that including wasmtime, even when not using wasmtime directly, heavily affects runtime performance. This is not only reflected in the increased startuptime but affects the runtime performance overall. Here are the benchmarks for startuptimes for different configurations. Important to note is that all of runtime is affected, but the startuptime is a decent proxy to measure runtime performance: ``` No wasm Time (mean ± σ): 50.5 ms ± 1.5 ms [User: 32.8 ms, System: 12.3 ms] Range (min … max): 48.3 ms … 54.4 ms 56 runs Wasm, lto=thin Time (mean ± σ): 104.9 ms ± 3.5 ms [User: 86.5 ms, System: 12.7 ms] Range (min … max): 99.5 ms … 111.1 ms 26 runs Wasm, lto=true Time (mean ± σ): 83.8 ms ± 2.5 ms [User: 65.8 ms, System: 12.1 ms] Range (min … max): 80.5 ms … 93.3 ms 31 runs Wasm, lto=true, strip="none", incremental=false, codegen-units=1, panic="abort" Time (mean ± σ): 53.1 ms ± 1.0 ms [User: 35.5 ms, System: 12.5 ms] Range (min … max): 50.6 ms … 55.5 ms 54 runs ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
this will now instead output