PCC: x64: insertlane instructions read only scalar-sized values. #8207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind adding more variants for loading floats, in addition to the variants for storing everything? (module
(memory 1)
(func (param v128 i32) (result v128)
local.get 0
local.get 1
f32.load
f32x4.replace_lane 0)
(func (param v128 i32) (result v128)
local.get 0
local.get 1
f64.load
f64x2.replace_lane 1)
(func (param v128 i32) (result v128)
local.get 0
local.get 1
f64.load
f64x2.replace_lane 0)
(func (param v128 i32)
local.get 1
local.get 0
f64x2.extract_lane 1
f64.store)
(func (param v128 i32)
local.get 1
local.get 0
f32x4.extract_lane 1
f32.store)
(func (param v128 i32)
local.get 1
local.get 0
i8x16.extract_lane_s 1
i32.store8)
(func (param v128 i32)
local.get 1
local.get 0
i16x8.extract_lane_s 1
i32.store16)
(func (param v128 i32)
local.get 1
local.get 0
i32x4.extract_lane 1
i32.store)
(func (param v128 i32)
local.get 1
local.get 0
i64x2.extract_lane 1
i64.store)
) |
|
Also I'd recommend running the test with/without AVX to confirm that that all works too |
cfallin
force-pushed
the
fix-pcc-insertlane
branch
from
583a0a3
to
6a66e1e
Compare
|
Sure, added additional cases, thanks! This surfaced another issue with the range-fact clamping on 128-bit values, now fixed. The test cases already had distinct AVX and non-AVX variants; added your new cases to both. |
|
race |
|
Yep, I imagine you'll want to review the new changes just pushed, sorry! |
fitzgen
approved these changes
Mar 21, 2024
github-actions
bot
added
cranelift
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Also fix `clamp_range` on greater-than-64-bit values: no range fact is possible in this case (propagate `Option` a bit deeper to represent this). Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=67538.
cfallin
force-pushed
the
fix-pcc-insertlane
branch
from
6a66e1e
to
633d6e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=67538.