-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of Tunables
on cross-compiles
#7844
Conversation
Subscribe to Label Action
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
To modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
This commit fixes how Wasmtime handles `Tunables` when targetting non-host platforms (or namely platforms with different pointer widths). Previously the host's `Tunables` would always be used instead of the target's tunables which meant that modules couldn't be loaded on the other platform due to the host having differing tunables by default. This commit updates tunables in `wasmtime::Config` to all be optional and loading the actual `Tunables` is deferred until the target is known during `Engine`-creation time.
c4a859a
to
8747597
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This commit fixes how Wasmtime handles
Tunables
when targetting non-host platforms (or namely platforms with different pointer widths). Previously the host'sTunables
would always be used instead of the target's tunables which meant that modules couldn't be loaded on the other platform due to the host having differing tunables by default.This commit updates tunables in
wasmtime::Config
to all be optional and loading the actualTunables
is deferred until the target is known duringEngine
-creation time.