Enable the component model by default #7821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the component model by default in the embedding API and the CLI. This means that an opt-in of `-W component-model` is no longer required and additionally `.wasm_component_model(true)` is no longer required. Note that this won't impact existing embeddings since the component model feature doesn't do much less `wasmtime::component` is used, and if that's being used this is probably good news for you.
pchickey
approved these changes
Jan 25, 2024
alexcrichton
force-pushed
the
enable-component-model
branch
from
5917a52
to
1a2ab5d
Compare
alexcrichton
force-pushed
the
enable-component-model
branch
from
1a2ab5d
to
5917a52
Compare
elliottt
approved these changes
Jan 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions
bot
added
wasmtime:api
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables the component model by default in the embedding API and the CLI. This means that an opt-in of
-W component-modelis no longer required and additionally.wasm_component_model(true)is no longer required. Note that this won't impact existing embeddings since the component model feature doesn't do much lesswasmtime::componentis used, and if that's being used this is probably good news for you.