More spaceship patterns #7702
Merged
More spaceship patterns #7702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottmcm
commented
Dec 18, 2023
| @@ -4,16 +4,23 @@ | |||
| (rule (simplify (select ty _ x x)) x) | |||
| (rule (simplify (bitselect ty _ x x)) x) | |||
|
|
|||
| ;; Push zeroes to the right -- this makes the select `truthy`, as used elsewhere | |||
There was a problem hiding this comment.
Specifically this truthy part:
github-actions
bot
added
cranelift
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "isle"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #7636 that added the spaceship patterns.
In particular, I noticed that what Rust currently does in
sort_byhttps://github.com/rust-lang/rust/blob/bf9229a2e366b4c311f059014a4aa08af16de5d8/library/core/src/slice/mod.rs#L3008
is a simplification pattern that I'd missed, so this adds that, and a couple other related things I saw in the area.