Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate debug builtins behind a Cargo feature #7305

Merged

Conversation

alexcrichton
Copy link
Member

This doesn't shave off much but can help tidy up some symbols from exported objects if they aren't needed.

This doesn't shave off much but can help tidy up some symbols from
exported objects if they aren't needed.
@alexcrichton alexcrichton requested review from a team as code owners October 19, 2023 22:55
@alexcrichton alexcrichton requested review from pchickey and removed request for a team October 19, 2023 22:55
@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label Oct 20, 2023
@github-actions
Copy link

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alexcrichton alexcrichton added this pull request to the merge queue Oct 20, 2023
Merged via the queue into bytecodealliance:main with commit 5565b93 Oct 20, 2023
18 checks passed
@alexcrichton alexcrichton deleted the gate-debug-builtins branch October 20, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants