Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-api/cmake: Support custom build options #7226

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

rockwotj
Copy link
Contributor

@rockwotj rockwotj commented Oct 12, 2023

This can be useful if you want change to set the features wasmtime
builds with in CMake

This can be useful if you want change to set the features wasmtime
builds with in CMake

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj rockwotj requested a review from a team as a code owner October 12, 2023 15:53
@rockwotj rockwotj requested review from alexcrichton and removed request for a team October 12, 2023 15:53
@rockwotj
Copy link
Contributor Author

Our use case we only want to turn on the async feature and disable others, so we can configure like so (semicolons are lists and prevent quoting amazingly):

cmake .. -DWASMTIME_USER_CARGO_BUILD_OPTIONS='--no-default-features;--features=async'

@github-actions github-actions bot added the wasmtime:c-api Issues pertaining to the C API. label Oct 12, 2023
@github-actions
Copy link

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton alexcrichton added this pull request to the merge queue Oct 13, 2023
Merged via the queue into bytecodealliance:main with commit 81b14a5 Oct 13, 2023
18 checks passed
@rockwotj rockwotj deleted the cmake-opts branch October 13, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:c-api Issues pertaining to the C API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants