Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some no-longer-necessary Ok-wrapping #7205

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Remove some no-longer-necessary Ok-wrapping #7205

merged 1 commit into from
Oct 10, 2023

Conversation

alexcrichton
Copy link
Member

Since #7152 the error types of sync and async are the same so much of the prior Ok-wrapping isn't necessary any more.

@alexcrichton
Remove some no-longer-necessary Ok-wrapping
c6c0d27 
Since bytecodealliance#7152 the error types of sync and async are the same so much of
the prior `Ok`-wrapping isn't necessary any more.
@alexcrichton alexcrichton requested a review from a team as a code owner October 10, 2023 12:00
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team October 10, 2023 12:00
@github-actions github-actions bot added the wasi Issues pertaining to WASI label Oct 10, 2023
@alexcrichton alexcrichton added this pull request to the merge queue Oct 10, 2023
Merged via the queue into bytecodealliance:main with commit 1abac1e Oct 10, 2023
18 checks passed
@alexcrichton alexcrichton deleted the less-ok-wrapping branch October 10, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrown abrown abrown approved these changes

@fitzgen fitzgen Awaiting requested review from fitzgen fitzgen is a code owner automatically assigned from bytecodealliance/wasmtime-core-reviewers

Assignees
No one assigned
Labels
wasi Issues pertaining to WASI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcrichton @abrown