Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor HTTP tests to be less flaky and more robust #7143

Merged
merged 7 commits into from
Oct 4, 2023
Merged

Refactor HTTP tests to be less flaky and more robust #7143

merged 7 commits into from
Oct 4, 2023

Commits on Oct 4, 2023

  1. Refactor HTTP tests to be less flaky and more robust 

    This commit refactors the wasi-http tests we have in this repository
with a few changes:

* Each test now uses a dedicated port for the test. The port 0 is bound
  and whatever the OS gives is used for the duration of the test. This
  prevents tests from possibly interfering with each other.

* Server spawning is abstracted behind a single `Server` type now which
  internally has http1/2 constructors.

* Timeouts for server shutdown are removed since they were failing in CI
  and are likely best handled for each test individually if necessary.

As a minor cleanup the `tokio` usage in guest programs was removed as it
was boilerplate in this case. This shouldn't affect the runtimes of
tests, however.
    @alexcrichton
    alexcrichton committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    6521e66 View commit details
    Browse the repository at this point in the history

  2. Remove unused import

    @alexcrichton
    alexcrichton committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    5544509 View commit details
    Browse the repository at this point in the history

  3. Don't panic from worker thread

    @alexcrichton
    alexcrichton committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    0fb051a View commit details
    Browse the repository at this point in the history

  4. Improve failure error message 

    prtest:full
    @alexcrichton
    alexcrichton committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    f960088 View commit details
    Browse the repository at this point in the history

  5. Fix some windows-specific issues

    @alexcrichton
    alexcrichton committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d0154cd View commit details
    Browse the repository at this point in the history

  6. Fix async tests

    @alexcrichton
    alexcrichton committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    2ad9f74 View commit details
    Browse the repository at this point in the history

  7. Relax test assertion string

    @alexcrichton
    alexcrichton committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    29c11f1 View commit details
    Browse the repository at this point in the history