[s390x] Improve handling of negative i32 constants #6952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After bytecodealliance#6850 was merged, the s390x back-end now always uses iilf instead of lhi to load negative constants, which is a small code size regression. Fix the isle predicate to get back lhi whenever possible.
cfallin
approved these changes
Sep 1, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Looks like a flaky test with wasi-sockets (cc @sunfishcode?) -- retrying the merge. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Hmm, the socket test is failing again -- @sunfishcode would you mind taking a look at this test? The PR changes only s390x stuff so shouldn't affect a macOS/x86-64 execution. |
github-actions
bot
added
the
cranelift
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Sep 6, 2023
…6952) After bytecodealliance#6850 was merged, the s390x back-end now always uses iilf instead of lhi to load negative constants, which is a small code size regression. Fix the isle predicate to get back lhi whenever possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #6850 was merged, the s390x back-end now always uses iilf instead of lhi to load negative constants, which is a small code size regression.
Fix the isle predicate to get back lhi whenever possible.