Backport: "Cranelift: avoid quadratic behavior in label-fixup processing" to 12.0.1 #6897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dealliance#6804) * WIP: two-tier processing for MachBuffer veneer processing in island emission * Unconditionally emit veneers for label forward-refs that cross islands. * Clean up and fix tests * Review feedback * Add some more detailed comments.
github-actions
bot
added
cranelift
|
To confirm, @cfallin do you have any reservations about the backport here and a point release? If not I can do the motions after merging this. |
cfallin
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
LGTM, thanks! @alexcrichton indeed feel free to do the release; thank you for offering!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #6804 to 12.0.1.
Fixes: #6889
I am unfamiliar with backporting and followed those docs let me know if there are additional steps to follow.