Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi-nn: remove BackendKind, add wrapper structs #6893

Merged
merged 5 commits into from
Aug 25, 2023
Merged

wasi-nn: remove BackendKind, add wrapper structs #6893

merged 5 commits into from
Aug 25, 2023

Commits on Aug 23, 2023

  1. wasi-nn: accept a list of backends instead of a hash map

    @abrown
    abrown committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1b32742 View commit details
    Browse the repository at this point in the history

  2. wasi-nn: refactor with new Backend and Registry wrappers 

    The wasi-nn crate uses virtual dispatch to handle different kinds of
backends and registries. For easier use, these items are now wrapped in
their own `Box<dyn ...>` structs.
    @abrown
    abrown committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    58c58ed View commit details
    Browse the repository at this point in the history

  3. wasi-nn: completely remove BackendKind 

    This change completely removes the `BackendKind` enum, which uniquely
listed the kinds of backends that the wasi-nn crate contained. Since we
allow many kinds of backends in `WasiNnCtx` which can be implemented
even outside the crate, this `BackendKind` enum no longer makes sense.
This change uses `GraphEncoding` instead.
    @abrown
    abrown committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    bbeb6e0 View commit details
    Browse the repository at this point in the history

  4. nit: move pub mod backend with other exports 

    prtest:full
    @abrown
    abrown committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d9f61b3 View commit details
    Browse the repository at this point in the history

  5. fix: remove broken doc links

    @abrown
    abrown committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    396d178 View commit details
    Browse the repository at this point in the history