Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winch(x64): Add support for return and unreachable #6612

Conversation

saulecabrera
Copy link
Member

@saulecabrera saulecabrera commented Jun 21, 2023

This change adds support for the return and unreachable
instructions. This change builds on top of the control flow building
blocks introduced in #6603

@saulecabrera saulecabrera force-pushed the winch-control-flow-handle-unreachable-return branch from 04d7f35 to 99da4f7 Compare June 21, 2023 01:47
@github-actions github-actions bot added fuzzing Issues related to our fuzzing infrastructure winch Winch issues or pull requests labels Jun 21, 2023
@github-actions
Copy link

Subscribe to Label Action

cc @fitzgen, @saulecabrera

This issue or pull request has been labeled: "fuzzing", "winch"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing
  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@saulecabrera saulecabrera force-pushed the winch-control-flow-handle-unreachable-return branch 4 times, most recently from fbedafa to a5892d9 Compare June 21, 2023 16:26
This change adds support for the `return` and `unreachable`
instructions. This change builds on top of the control flow building
blocks introduced in bytecodealliance#6603
@saulecabrera saulecabrera force-pushed the winch-control-flow-handle-unreachable-return branch from a5892d9 to 3135c34 Compare June 21, 2023 17:14
@saulecabrera saulecabrera marked this pull request as ready for review June 21, 2023 17:16
@saulecabrera saulecabrera requested review from a team as code owners June 21, 2023 17:16
@saulecabrera saulecabrera requested review from itsrainy, jameysharp and alexcrichton and removed request for a team, itsrainy and jameysharp June 21, 2023 17:16
@saulecabrera saulecabrera added this pull request to the merge queue Jun 21, 2023
Merged via the queue into bytecodealliance:main with commit 404711b Jun 21, 2023
@saulecabrera saulecabrera deleted the winch-control-flow-handle-unreachable-return branch June 21, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzzing Issues related to our fuzzing infrastructure winch Winch issues or pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants