Add integer binary instructions to Winch #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcharles
requested review from
alexcrichton and
abrown
and removed request for
a team
github-actions
bot
added
fuzzing
Subscribe to Label Action
This issue or pull request has been labeled: "fuzzing", "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
saulecabrera
reviewed
Jun 7, 2023
winch/codegen/src/isa/x64/asm.rs
Outdated
Comment on lines
327
to
330
| _ => panic!( | ||
| "Invalid operand combination for and; src = {:?} dst = {:?}", | ||
| src, dst | ||
| ), |
There was a problem hiding this comment.
I believe for this and all the other functions below, we can use Self::handle_invalid_operand_combination?
There was a problem hiding this comment.
I also noticed I can substitute self.load_constant for self.move_ir when loading a larger than 32-bit integer into the scratch register so I'll make that change too.
saulecabrera
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6528. Adds x86 support for a number of integer binary instructions to Winch.