Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for binary/octal literals to ISLE #6234

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Add support for binary/octal literals to ISLE #6234

merged 3 commits into from
Apr 18, 2023

Commits on Apr 18, 2023

  1. Add support for binary/octal literals to ISLE 

    In a number of x64-changes recently some u8 immediates are interpreted
as four bit-packed 2-bit numbers and I have a tough time going between
hex and these bit-packed numbers. I've been writing `0xAA == 0b...` in
comments to indicate the intent but I figured it'd be a bit clearer if
the binary literal was accepted directly!

This is a minor update to the ISLE lexer to allow for binary `0b00...`
and octal `0o00...` literals in the same manner as hex literals. Some
comments in the x64 backend are then removed to use the binary literal
syntax directly.
    @alexcrichton
    alexcrichton committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    11ffaa1 View commit details
    Browse the repository at this point in the history

  2. Update ISLE reference for octal/binary

    @alexcrichton
    alexcrichton committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    e363539 View commit details
    Browse the repository at this point in the history

  3. Update ISLE tests for octal/binary

    @alexcrichton
    alexcrichton committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    e364094 View commit details
    Browse the repository at this point in the history