Rename as_bool to as_truthy, and fix TypeSet::as_bool
#6027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/rename-as-bool
branch
from
97af007
to
1acdac4
Compare
elliottt
commented
Mar 15, 2023
Comment on lines
-449
to
+458
| copy.ints = NumSet::new(); | ||
|
|
||
| // If this type set represents a scalar, `as_truthy` produces an I8, otherwise it returns a | ||
| // vector of the same number of lanes, whose elements are integers of the same width. For | ||
| // example, F32X4 gets turned into I32X4, while I32 gets turned into I8. | ||
| if self.lanes.len() == 1 && self.lanes.contains(&1) { | ||
| copy.ints = NumSet::from([8]); | ||
| } else { | ||
| copy.ints.extend(&self.floats) | ||
| } | ||
|
|
There was a problem hiding this comment.
Here's the bug fix for TypeSet::as_truthy. I've also updated the tests to ensure this is doing what we expect now, given the semantics of as_truthy_pedantic.
github-actions
bot
added
cranelift
jameysharp
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
This all looks correct, thanks!
I don't know if it really makes sense to special-case scalar truthy values to always be I8, but we don't have to figure that out right now. I believe this PR is consistent with the current state of our instruction definitions, at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
as_boolfunctions in cranelift-codegen-meta toas_truthyto better describe their behavior. Additionally, fix the implementation ofTypeSet::as_truthyto match the behavior ofType::as_truthy, as it was returning an emptyTypeSetwhen it should have been mirroring the behavior.This bug was introduced in #5031 when we removed booleans from cranelift.