wasmtime: Add libc as a dependency on FreeBSD in the jit-icache-coherence crate
#5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rence` crate This gets this package to build for `x86_64`, but does not include any cache clearing for `aarch64-freebsd`. Which will probably build, but not work. As far as I can tell membarriers are still in the process of being added. See: https://reviews.freebsd.org/D32360 Since FreeBSD is mirroring the Linux membarrier syscall we may be able to reuse the same implementation for both Linux and FreeBSD for AArch64.
|
Thanks!
That is enough for my purposes :) |
alexcrichton
approved these changes
Nov 28, 2022
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Jan 1, 2023
We accidentally broke the build for FreeBSD when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build. See bytecodealliance#5323 and bytecodealliance#5331 for context.
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Jan 1, 2023
We accidentally broke the build for FreeBSD when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build. See bytecodealliance#5323 and bytecodealliance#5331 for context.
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Jan 1, 2023
We accidentally broke the build for FreeBSD when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build. See bytecodealliance#5323 and bytecodealliance#5331 for context.
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Jan 1, 2023
We accidentally broke the build for Android when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build. See bytecodealliance#5323 and bytecodealliance#5331 for context.
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Jan 3, 2023
We accidentally broke the build for FreeBSD when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build. See bytecodealliance#5323 and bytecodealliance#5331 for context.
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Jan 3, 2023
We accidentally broke the build for FreeBSD when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build. See bytecodealliance#5323 and bytecodealliance#5331 for context.
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Jan 3, 2023
We accidentally broke the build for Android when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build. See bytecodealliance#5323 and bytecodealliance#5331 for context.
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Jan 3, 2023
We accidentally broke the build for Android when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build. See bytecodealliance#5323 and bytecodealliance#5331 for context.
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Jan 3, 2023
We accidentally broke the build for Android when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build. See bytecodealliance#5323 and bytecodealliance#5331 for context.
alexcrichton
pushed a commit
that referenced
this pull request
Jan 3, 2023
afonso360
added a commit
to afonso360/wasmtime
that referenced
this pull request
Jan 3, 2023
We accidentally broke the build for Android when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build. See bytecodealliance#5323 and bytecodealliance#5331 for context.
alexcrichton
pushed a commit
that referenced
this pull request
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This gets this package to build for
x86_64, but does not include any cache clearing foraarch64-freebsd. Which will probably build, but not work.As far as I can tell membarriers are still in the process of being added.
See: https://reviews.freebsd.org/D32360
Since FreeBSD is mirroring the Linux membarrier syscall we may be able to reuse the same implementation for both Linux and FreeBSD for AArch64.
I wasn't able to test FreeBSD directly but cg_clif builds and passes its tests with this commit applied to the v3.0.0 tag. (CI)
Fixes: #5308
cc: @bjorn3