Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

egraph-based midend: draw the rest of the owl (productionized). #4953

Merged
merged 61 commits into from
Oct 12, 2022
Merged

egraph-based midend: draw the rest of the owl (productionized). #4953

merged 61 commits into from
Oct 12, 2022

Commits on Sep 23, 2022

  1. egraph-based midend: draw the rest of the owl.

    @cfallin
    cfallin committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    e54cdef View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Rename egg submodule of cranelift-codegen to egraph.

    @cfallin
    cfallin committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    e43bc64 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Apply some feedback from @JSharp during code walkthrough.

    @cfallin
    cfallin committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    e01e8f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Remove recursion from find_best_node by doing a single pass. 

    Rather than recursively computing the lowest-cost node for a given
eclass and memoizing the answer at each eclass node, we can do a single
forward pass; because every eclass node refers only to earlier nodes,
this is sufficient. The behavior may slightly differ from the earlier
behavior because we cannot short-circuit costs to zero once a node is
elaborated; but in practice this should not matter.
    @cfallin
    cfallin committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    8f9b5ad View commit details
    Browse the repository at this point in the history

  2. Make elaboration non-recursive. 

    Use an explicit stack instead (with `ElabStackEntry` entries,
alongside a result stack).
    @cfallin
    cfallin committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    0b954b6 View commit details
    Browse the repository at this point in the history

  3. Make elaboration traversal of the domtree non-recursive/stack-safe.

    @cfallin
    cfallin committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    58b509f View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Work analysis logic in Cranelift-side egraph glue into a general anal… 

    …ysis framework in cranelift-egraph.
    @cfallin
    cfallin committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    9275d0c View commit details
    Browse the repository at this point in the history

  2. Apply static recursion limit to rule application.

    @cfallin
    cfallin committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    01d491a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into mid-end

    @cfallin
    cfallin committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    dbbfd8b View commit details
    Browse the repository at this point in the history

  4. Fix aarch64 wrt dynamic-vector support -- broken rebase.

    @cfallin
    cfallin committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    a53984d View commit details
    Browse the repository at this point in the history

  5. Topo-sort cranelift-egraph before cranelift-codegen in publish script… 

    …, like the comment instructs me to!
    @cfallin
    cfallin committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    97bc58b View commit details
    Browse the repository at this point in the history

  6. Fix multi-result call testcase.

    @cfallin
    cfallin committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    8681c76 View commit details
    Browse the repository at this point in the history

  7. Include cranelift-egraph in PUBLISHED_CRATES.

    @cfallin
    cfallin committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    c211c56 View commit details
    Browse the repository at this point in the history

  8. Fix atomic_rmw: not really a load.

    @cfallin
    cfallin committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    d673f95 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Merge remote-tracking branch 'upstream/main' into mid-end

    @cfallin
    cfallin committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    9e68cc6 View commit details
    Browse the repository at this point in the history

  2. Remove now-unnecessary PartialOrd/Ord derivations.

    @cfallin
    cfallin committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    bb0bc99 View commit details
    Browse the repository at this point in the history

  3. Address some code-review comments.

    @cfallin
    cfallin committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    a31bc05 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Review feedback.

    @cfallin
    cfallin committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    3660bd6 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into mid-end

    @cfallin
    cfallin committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    e992197 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Review feedback.

    @cfallin
    cfallin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    676a72d View commit details
    Browse the repository at this point in the history

  2. No overlap in mid-end rules, because we are defining a multi-construc… 

    …tor.
    @cfallin
    cfallin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    23f8066 View commit details
    Browse the repository at this point in the history

  3. rustfmt

    @cfallin
    cfallin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    d3f1ece View commit details
    Browse the repository at this point in the history

  4. Review feedback.

    @cfallin
    cfallin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    248065a View commit details
    Browse the repository at this point in the history

  5. Review feedback.

    @cfallin
    cfallin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    15fd6b9 View commit details
    Browse the repository at this point in the history

  6. Review feedback.

    @cfallin
    cfallin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    fb2cb33 View commit details
    Browse the repository at this point in the history

  7. Review feedback.

    @cfallin
    cfallin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    96e379d View commit details
    Browse the repository at this point in the history

  8. Remove redundant mut.

    @cfallin
    cfallin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    95a393f View commit details
    Browse the repository at this point in the history

  9. Add comment noting what rules can do.

    @cfallin
    cfallin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    c9646c2 View commit details
    Browse the repository at this point in the history

  10. Review feedback.

    @cfallin
    cfallin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    b967925 View commit details
    Browse the repository at this point in the history

  11. Clarify comment wording.

    @cfallin
    cfallin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    ccec8ea View commit details
    Browse the repository at this point in the history

  12. Update has_memory_fence_semantics.

    @cfallin
    cfallin committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    f5cb2c2 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Apply @jameysharp's improved loop-level computation. 

    Co-authored-by: Jamey Sharp <jamey@minilop.net>
    @cfallin @jameysharp
    cfallin and jameysharp authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    f39b1cc View commit details
    Browse the repository at this point in the history

  2. Fix suggestion commit.

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    2f5c66e View commit details
    Browse the repository at this point in the history

  3. Fix off-by-one in new loop-nest analysis.

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    71a0078 View commit details
    Browse the repository at this point in the history

  4. Review feedback.

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    9b2989b View commit details
    Browse the repository at this point in the history

  5. Review feedback.

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    75b9d2e View commit details
    Browse the repository at this point in the history

  6. Review feedback.

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    17809c6 View commit details
    Browse the repository at this point in the history

  7. Use Default, not std::default::Default, as per @fitzgen 

    Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
    @cfallin @fitzgen
    cfallin and fitzgen authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    5fbc64c View commit details
    Browse the repository at this point in the history

  8. Apply @fitzgen's comment elaboration to a doc-comment. 

    Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
    @cfallin @fitzgen
    cfallin and fitzgen authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    a1fdd35 View commit details
    Browse the repository at this point in the history

  9. Add stat for hitting the rewrite-depth limit.

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    c5de3a0 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'upstream/main' into mid-end

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    81819ed View commit details
    Browse the repository at this point in the history

  11. Some code motion in split prelude to make the diff a little clearer w… 

    …rt `main`.
    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    4b1aa37 View commit details
    Browse the repository at this point in the history

  12. Take @jameysharp's suggested try_into() usage for blockparam indices. 

    Co-authored-by: Jamey Sharp <jamey@minilop.net>
    @cfallin @jameysharp
    cfallin and jameysharp authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    3721cec View commit details
    Browse the repository at this point in the history

  13. Take @jameysharp's suggestion to avoid double-match on load op. 

    Co-authored-by: Jamey Sharp <jamey@minilop.net>
    @cfallin @jameysharp
    cfallin and jameysharp authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    15e0d31 View commit details
    Browse the repository at this point in the history

  14. Fix suggestion (add import).

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    768ad06 View commit details
    Browse the repository at this point in the history

  15. Review feedback.

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    a36c5dc View commit details
    Browse the repository at this point in the history

  16. Fix stack_load handling.

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    f86242b View commit details
    Browse the repository at this point in the history

  17. Remove redundant can_store case.

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    19bf37e View commit details
    Browse the repository at this point in the history

  18. Take @jameysharp's suggested improvement to FuncEGraph::build() logic 

    Co-authored-by: Jamey Sharp <jamey@minilop.net>
    @cfallin @jameysharp
    cfallin and jameysharp authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    c69f753 View commit details
    Browse the repository at this point in the history

  19. Tweaks to FuncEGraph::build() on top of suggestion.

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    9a7feef View commit details
    Browse the repository at this point in the history

  20. Take @jameysharp's suggested clarified condition 

    Co-authored-by: Jamey Sharp <jamey@minilop.net>
    @cfallin @jameysharp
    cfallin and jameysharp authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    04d1617 View commit details
    Browse the repository at this point in the history

  21. Clean up after suggestion (unused variable).

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    32640e2 View commit details
    Browse the repository at this point in the history

  22. Fix loop analysis.

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    bf9f673 View commit details
    Browse the repository at this point in the history

  23. loop level asserts

    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    0d7ae78 View commit details
    Browse the repository at this point in the history

  24. Revert constant-space loop analysis -- edge cases were incorrect, so … 

    …let's go with the simple thing for now.
    @cfallin
    cfallin committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    4bd3e9c View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Take @jameysharp's suggestion re: result_tys 

    Co-authored-by: Jamey Sharp <jamey@minilop.net>
    @cfallin @jameysharp
    cfallin and jameysharp authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    9aadf51 View commit details
    Browse the repository at this point in the history

  2. Fix up after suggestion

    @cfallin
    cfallin committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    a13ead2 View commit details
    Browse the repository at this point in the history

  3. Take @jameysharp's suggestion to use fold rather than reduce 

    Co-authored-by: Jamey Sharp <jamey@minilop.net>
    @cfallin @jameysharp
    cfallin and jameysharp authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    0a9f2ab View commit details
    Browse the repository at this point in the history

  4. Fixup after suggestion

    @cfallin
    cfallin committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    70b1c10 View commit details
    Browse the repository at this point in the history

  5. Take @jameysharp's suggestion to remove elaborate_eclass_use's return… 

    … value.
    @cfallin
    cfallin committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    8b4be05 View commit details
    Browse the repository at this point in the history

  6. Clarifying comment in terminator insts.

    @cfallin
    cfallin committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    ec8a1a9 View commit details
    Browse the repository at this point in the history