Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "cranelift: Register all functions in test file for interpreter (#4800)" #4810

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

cfallin
Copy link
Member

@cfallin cfallin commented Aug 30, 2022

This reverts commit 500a9f1.

It is currently causing a test regression on main (comment).

@cfallin cfallin enabled auto-merge (squash) August 30, 2022 00:15
@jameysharp
Copy link
Contributor

jameysharp commented Aug 30, 2022

Can we just undo the addition of test interpret on filetests/filetests/runtests/call.clif? That's enough to make the tests pass for me again locally.

I'm puzzled that CI passed this PR since it must have run these tests. I assume there was some interaction between #4800 and #4782.

@cfallin
Copy link
Member Author

cfallin commented Aug 30, 2022

I don't mind too much either way, but for the sake of setting precedent I'd prefer to keep to the simple principle of "revert PR and get back to green CI asap". More than half of my reasoning there is just that the CI is fairly close to done here and I don't want to delay the fix further :-)

@jameysharp
Copy link
Contributor

Yeah, that's fair!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants