Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AArch64: port misc ops to ISLE. #4796

Merged
merged 2 commits into from
Aug 29, 2022
Merged

AArch64: port misc ops to ISLE. #4796

merged 2 commits into from
Aug 29, 2022

Conversation

cfallin
Copy link
Member

@cfallin cfallin commented Aug 26, 2022

  • get_pinned_reg / set_pinned_reg
  • bitcast
  • stack_addr
  • extractlane
  • insertlane
  • vhigh_bits
  • iadd_ifcout
  • fcvt_low_from_sint

After this PR and the load/store porting in #4785, we have only tls_value and flag-dependent ops remaining.

@cfallin cfallin requested a review from elliottt August 26, 2022 23:50
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:aarch64 Issues related to AArch64 backend. labels Aug 26, 2022
elliottt
elliottt approved these changes Aug 27, 2022
View reviewed changes
Copy link
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@elliottt
Copy link
Member

It looks like there are only precise-output tests in the aarch64 backend for extractlane and stack_addr. Should we pull some over from the x64 tests and regenerate their output for coverage before merging this?

@cfallin
Add some precise-output compile tests for aarch64.
3513a33
@cfallin
AArch64: port misc ops to ISLE.
4812dd6 
- get_pinned_reg / set_pinned_reg
- bitcast
- stack_addr
- extractlane
- insertlane
- vhigh_bits
- iadd_ifcout
- fcvt_low_from_sint
@cfallin
Copy link
Member Author

cfallin commented Aug 27, 2022

It looks like there are only precise-output tests in the aarch64 backend for extractlane and stack_addr. Should we pull some over from the x64 tests and regenerate their output for coverage before merging this?

Great point; I've added tests so all the opcodes listed above have some precise-output compile tests in filetests/isa/aarch64/ now. The first commit adds them with precise-output updated to match main prior to this PR; the second commit includes this PR's work and updates to the tests.

@cfallin cfallin merged commit a6eb24b into bytecodealliance:main Aug 29, 2022
@cfallin cfallin deleted the aarch64-isle-misc branch August 29, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottt elliottt elliottt approved these changes

@akirilov-arm akirilov-arm Awaiting requested review from akirilov-arm

Assignees
No one assigned
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfallin @elliottt