Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x64: Lower extractlane, scalar_to_vector, and splat in ISLE #4780

Merged
merged 6 commits into from
Aug 25, 2022
Merged

x64: Lower extractlane, scalar_to_vector, and splat in ISLE #4780

merged 6 commits into from
Aug 25, 2022

Conversation

elliottt
Copy link
Member

Lower extractlane, scalar_to_vector and splat in ISLE.

I also made some changes to the SinkableLoad api

  • change the return type of sink_load to RegMem as there are more functions available for dealing with RegMem
  • add reg_mem_to_reg_mem_imm and register it as an automatic conversion

@elliottt elliottt marked this pull request as ready for review August 25, 2022 00:23
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:x64 Issues related to x64 codegen isle Related to the ISLE domain-specific language labels Aug 25, 2022
@github-actions
Copy link

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "cranelift:area:machinst", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

abrown
abrown approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for retaining the existing behavior.

@elliottt elliottt merged commit 9386409 into bytecodealliance:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrown abrown abrown approved these changes

Assignees
No one assigned
Labels
cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliottt @abrown