Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

components: Fix support for 0-sized flags #4560

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

alexcrichton
Copy link
Member

This commit goes through and updates support in the various argument
passing routines to support 0-sized flags. A bit of a degenerate case
but clarified in WebAssembly/component-model#76 as intentional.

@alexcrichton
Copy link
Member Author

cc @dicej as well

Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a correct implementation of the changed spec to me!

@alexcrichton alexcrichton enabled auto-merge (squash) July 29, 2022 19:26
@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label Jul 29, 2022
@github-actions
Copy link

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

This commit goes through and updates support in the various argument
passing routines to support 0-sized flags. A bit of a degenerate case
but clarified in WebAssembly/component-model#76 as intentional.
@alexcrichton
Copy link
Member Author

I pushed up two test fixes for the failed CI:

  • One updates make_echo_component to support zero-sized types
  • The other updates the Lower structure generated by the various procedural macros to guarantee an alignment that matches ValRaw to satisfy assertions in Wasmtime. (probably not strictly necessary but seems better to be safe here)

@alexcrichton alexcrichton merged commit 893fadb into bytecodealliance:main Aug 1, 2022
@alexcrichton alexcrichton deleted the zero-size-flags branch August 1, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants