Enable generating debug symbols on AArch64 #4468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cranelift
jameysharp
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
This makes sense to me, and even if it turns out to be wrong I don't think it could break anything that works now. But I think @cfallin should take a look too.
jeffcharles
deleted the
jeffcharles.add-apple-silicon-support-for-debugging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables generating debug symbols for AArch64 as described in #4393.
This PR does this by using the same implementation as x86_64. This is needed or an error message is output and compilation fails when enabling generating debug symbols. I've tested debugging a few compiled modules on my M1 with LLDB and debugging seems to work reasonably well (or at least as well as on x86).
I'm not sure whom to add as a reviewer as there are no suggestions on the right.