fuzzgen: Generate stack load/store instructions #4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
github-actions
bot
added
the
cranelift
jameysharp
reviewed
Jul 13, 2022
Comment on lines
277
to
283
| let imm64 = match ty { | ||
| I8 => self.u.arbitrary::<i8>()? as i64, | ||
| I16 => self.u.arbitrary::<i16>()? as i64, | ||
| I32 => self.u.arbitrary::<i32>()? as i64, | ||
| I64 => self.u.arbitrary::<i64>()?, | ||
| ty if ty == I8 => self.u.arbitrary::<i8>()? as i64, | ||
| ty if ty == I16 => self.u.arbitrary::<i16>()? as i64, | ||
| ty if ty == I32 => self.u.arbitrary::<i32>()? as i64, | ||
| ty if ty == I64 => self.u.arbitrary::<i64>()?, | ||
| _ => unreachable!(), | ||
| }; |
There was a problem hiding this comment.
This change is unnecessary, right? I'd like to keep the simpler syntax unless there's some reason it needs to change.
There was a problem hiding this comment.
My editor was complaining that we were always matching on I8 as a variable name and that the others were unused.
But looking at it again it probably would also generate a compile warning, so i think it might be a bug in CLion.
Ill revert this change.
jameysharp
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR adds stack slots and stack loads and stores to the functions generated by fuzzgen. We use only the specialized instructions
stack_store/stack_loadand not the more general combo ofstack_addr+store/load.This also generates random stack slots, that are zero initialized on the first block of the function to prevent reading uninitialized memory.
This has run overnight on a (not very fast) x86 server, and so far hasn't found any issues.
cc: @cfallin @jameysharp