Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstancePre can impl Clone #3510

Merged
merged 1 commit into from
Nov 8, 2021
Merged

InstancePre can impl Clone #3510

merged 1 commit into from
Nov 8, 2021

Commits on Nov 6, 2021

  1. InstancePre can impl Clone 

    Its a manually written impl, not a derive, because InstancePre<T>: Clone
does not require T: Clone.

The clone should be reasonably inexpensive: Clone for Module is just an
Arc, and Clone for Definition should also just be an Arc on the HostFunc
or Instance variants. An InstancePre shouldnt contain any
Definition::Extern variants because there is not yet a Store associated
with it- right?
    Pat Hickey committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    ee153bf View commit details
    Browse the repository at this point in the history