cranelift: Fix invalid trampoline when returning boolean vectors #3341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This is a extension of #3306. In that PR we accidentally only dealt with receiving bool vectors as arguments to the callee function. This caused issues in #3332 where those tests were failing to run on the real backends, due to the generated trampoline being invalid when the callee returns bool vectors.
For more context about this, see this comment with the invalid trampoline, and the rest of the thread with a proposed solution.
The solution here is not great,
bint
with the correct type would fix this, but is not implemented in some backends, same withbmask
.raw_bitcast
solves the issue, but we really should fixbmask
/bint
and use that.Fixing trampoline bool args is tracked in #2237
Fixes #3334
Fixes #3335