Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hand written legalizations in simple_legalize #3007

Merged
merged 3 commits into from
Jun 21, 2021
Merged

Use hand written legalizations in simple_legalize #3007

merged 3 commits into from
Jun 21, 2021

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Jun 20, 2021 •
edited
Loading

This allows removal of the legalization dsl once the old backends are removed.

@bjorn3
Use hand written legalizations in simple_legalize
50e53a0 
This allows removal of the legalization dsl once the old backends are
removed.
@bjorn3
Remove all dsl legalizations for arm32, arm64 and s390x
1415dd8
@bjorn3 bjorn3 force-pushed the hand_written_legalization branch from b8f75ee to 1415dd8 Compare June 20, 2021 16:44
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:meta Everything related to the meta-language. labels Jun 20, 2021
@bjorn3 bjorn3 mentioned this pull request Jun 21, 2021
Merged
cfallin
cfallin approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was much simpler than I had feared it would be; and it's very nice to be finally removing the dependency on more CDSL machinery.

@cfallin cfallin merged commit 443eb7a into bytecodealliance:main Jun 21, 2021
@bjorn3 bjorn3 deleted the hand_written_legalization branch June 21, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallin cfallin cfallin approved these changes

Assignees
No one assigned
Labels
cranelift:meta Everything related to the meta-language. cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjorn3 @cfallin