Allow Async Stores with Fuel to Run Forever #2927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the OutOfGas::InjectFuel configuration to make the injection count optional, which allows stores to run forever.
theduke
force-pushed
the
async-yield-forever
branch
from
0115897
to
abb3978
Compare
github-actions
bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
|
Thanks for the PR! The original intention was that Personally I think that this, if still desired instead of |
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jun 30, 2021
This commit updates the type of the amount of times to inject fuel in the `out_of_fuel_async_yield` to `u64` instead of `u32`. This should allow effectively infinite fuel to get injected, even if a small amount of fuel is injected per iteration. Closes bytecodealliance#2927 Closes bytecodealliance#3046
alexcrichton
added a commit
that referenced
this pull request
Jul 1, 2021
* Change the injection count of fuel in a store from u32 to u64 This commit updates the type of the amount of times to inject fuel in the `out_of_fuel_async_yield` to `u64` instead of `u32`. This should allow effectively infinite fuel to get injected, even if a small amount of fuel is injected per iteration. Closes #2927 Closes #3046 * Fix tokio example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to configure an async store to run forever.
A fuel injection count has to be specified, which eventually reaches 0 and
causes a trap.
This changes the OutOfGas::InjectFuel configuration to make the injection
count optional, which allows stores to run forever.
NOTE: this is obviously a breaking API change.
It would also be possible to add an additional config method.