Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cranelift AArch64: Improve the Popcnt implementation #2589

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Cranelift AArch64: Improve the Popcnt implementation #2589

merged 1 commit into from
Jan 19, 2021

Conversation

akirilov-arm
Copy link
Contributor

Now the backend uses the Neon CNT instruction, which results into a major simplification.

Closes #1537 (which also contains performance data).

@akirilov-arm
Cranelift AArch64: Improve the Popcnt implementation
043a843 
Now the backend uses the CNT instruction, which results into a major
simplification.

Copyright (c) 2021, Arm Limited.
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. labels Jan 19, 2021
cfallin
cfallin approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks very much for looking into this!

@cfallin cfallin merged commit 0085ed3 into bytecodealliance:main Jan 19, 2021
@akirilov-arm akirilov-arm deleted the popcnt branch January 19, 2021 22:23
@bnjbvr
Copy link
Member

bnjbvr commented Jan 20, 2021

Thanks @akirilov-arm for the benchmarking and PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallin cfallin cfallin approved these changes

@bnjbvr bnjbvr Awaiting requested review from bnjbvr

Assignees
No one assigned
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cranelift aarch64 backend: implement 8/16/32-bit popcnt more efficiently
3 participants
@akirilov-arm @bnjbvr @cfallin