Fixes #2418: Enhance wiggle to generate its UserErrorConverstion trait with a function that returns Result<abi_err, String> #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscribe to Label Actioncc @kubkon
This issue or pull request has been labeled: "wasi"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fst-crenshaw
force-pushed
the
tlc/enhance_with_trapz
branch
from
d0c55c7
to
228ebad
Compare
…tion that returns a Result<abi_err, String>. This enhancement allows hostcall implementations using wiggle to return an actionable error to the instance (the abi_err) or to terminate the instance using the String as fatal error information.
…tion that returns a Result<abi_err, String>. This enhancement allows hostcall implementations using wiggle to return an actionable error to the instance (the abi_err) or to terminate the instance using the String as fatal error information.
…. Hostcall implementations generated by wiggle now return an Result<abi_error, Trap>. As a result, hostcalls experiencing fatal errors may trap, thereby terminating the wasmtime instance. This enhancement has been performed for both wasi snapshot1 and wasi snapshot0.
fst-crenshaw
force-pushed
the
tlc/enhance_with_trapz
branch
from
80eaf71
to
e693086
Compare
fst-crenshaw
force-pushed
the
tlc/enhance_with_trapz
branch
from
e5eccb9
to
7487b89
Compare
fst-crenshaw
commented
Nov 20, 2020
| } | ||
|
|
||
| #[no_mangle] | ||
| pub unsafe fn #c_abi_name( |
There was a problem hiding this comment.
For referenced, I recommended this get removed since it needed to get updated anyway and I don't think that anything is using this right now.
alexcrichton
approved these changes
Nov 24, 2020
fst-crenshaw
changed the title
|
@alexcrichton -- I believe this is ready to merge. I appreciate you! |
|
👍 |
cfallin
added a commit
to bytecodealliance/lucet
that referenced
this pull request
Nov 30, 2020
- Refer to a rebased branch of wasmtime that (temporarily) removes bytecodealliance/wasmtime#2419; that PR changed some APIs in a way that is not yet reflected in Lucet. - Update a `GuestMemory` impl in a slightly hamfisted way (every shared/mut borrow is "just a borrow"; imprecise but maybe still sound?) Both of these things should be fixed before merging; I just want to get a green CI again for testing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long-time listener, first-time caller.
I am submitting this WIP PR for issue #2418. Please see issue #2418 for a description.