reference types: Implement the table.size and table.grow instructions
#1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
force-pushed
the
table-size-and-table-grow
branch
from
a2740f0
to
6bc16b0
Compare
|
@alexcrichton ok, feedback addressed 👍 |
fitzgen
force-pushed
the
table-size-and-table-grow
branch
from
6bc16b0
to
f8419f0
Compare
alexcrichton
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Still doesn't handle
table.growforfuncrefs yet, as there are still some open questions about how to represent on-stack, in-Wasmfuncrefs.)Also de-duplicates / cleans up declaring builtin function indices a little bit, so that they aren't so tedious and repetitive.
Part of #929