Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wasm from rust docs #1719

Merged
merged 3 commits into from
May 18, 2020
Merged

Conversation

austinabell
Copy link
Contributor

Hello!

I was playing around with this and noticed the docs are a bit broken. Here are my changes:

  • Update wasmtime version in docs to 0.16.0
    • Breaking API changes from Refactor #1524 were made in the docs, but the old version was kept
  • Change second code wat example.
    • The run function does not return anything (I guess another option would be to return some value to keep the function call the same signature as previous but I think this may help some)
  • Expose the whole file code for the updated usage on the second example
    • Expanding from the previous example, it is confusing how the code is setup for this, as there is the other changes needed for this to run successfully
    • Open to suggestions or reverting this, as this is more opinionated

Link to docs for reference, if it helps: https://bytecodealliance.github.io/wasmtime/lang-rust.html

@github-actions github-actions bot added the wasmtime:docs Issues related to Wasmtime's documentation label May 16, 2020
@alexcrichton alexcrichton merged commit e40fd9d into bytecodealliance:master May 18, 2020
@alexcrichton
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:docs Issues related to Wasmtime's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants