Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using virtual files for stdin/out/err #1636

Closed
wants to merge 1 commit into from

Conversation

CryZe
Copy link
Contributor

@CryZe CryZe commented Apr 30, 2020

This adds the ability to use virtual files not only for the file system in WASI, but also for stdin, stdout and stderr.

@github-actions github-actions bot added the wasi Issues pertaining to WASI label Apr 30, 2020
@github-actions
Copy link

Subscribe to Label Action

cc @kubkon

This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

  • kubkon: wasi

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@kubkon
Copy link
Member

kubkon commented Apr 30, 2020

Hmm, I think this might be a potential duplicate of #1600.

@CryZe
Copy link
Contributor Author

CryZe commented Apr 30, 2020

Oh, you are right, that is indeed seemingly solving the same problem. Feel free to close this one then if the (apparently much more complex) approach there is the better long term one.

@kubkon
Copy link
Member

kubkon commented Apr 30, 2020

Oh, you are right, that is indeed seemingly solving the same problem. Feel free to close this one then if the (apparently much more complex) approach there is the better long term one.

I think we should hold off with the decision until there's a decision about #1561. If that one lands, then given all the design changes introduced to wasi-common, it'll make sense to close this one in favour of #1600. However, if we decide not go with #1561, then I'll be happy to land your fix instead. Oh, and thanks a lot for the PR! It's much appreciated! :-)

@whitequark
Copy link
Contributor

Looks like #1561 did land.

This adds the ability to use virtual files not only for the file system
in WASI, but also for stdin, stdout and stderr.
@kubkon
Copy link
Member

kubkon commented Jun 9, 2020

Thanks for the PR @CryZe. Since we’ve decided to go with #1600, this PR has now been superseded so I’ll go ahead and close it.

@kubkon kubkon closed this Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasi Issues pertaining to WASI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants