Add Go as an embedding to the book #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also take this time to list out all embeddings in the README of wasmtime itself.
github-actions
bot
added
the
wasmtime:docs
|
Since the README is so prominent, I'm curious how others feel about the links here. I chose to link to the book docs as well as the native language package (where possible), but it might perhaps be better to link to the API documention uniformly? What do others think? |
|
I think including the embeddings in the README is a very good idea! And I also like how you linked to things, so 👍 from me! |
sunfishcode
reviewed
Apr 7, 2020
|
Updated! |
sunfishcode
approved these changes
Apr 7, 2020
README.md
Outdated
| * **[.NET]** - the [`Wasmtime` NuGet package] | ||
| * **[Go]** - the [wasmtime-go repository] | ||
|
|
||
| [Rust]: https://bytecodealliance.github.io/wasmtime/embed-rust.html |
There was a problem hiding this comment.
This should point to lang-rust.html now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also take this time to list out all embeddings in the README of wasmtime
itself.